Review Request 119934: Make "nothing interesting going on" labels in applets consistent
Kai Uwe Broulik
kde at privat.broulik.de
Mon Aug 25 18:40:36 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119934/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-workspace
Description
-------
This makes the labels for "No notifications", "No devices" and "No media playing" consistent. I took the one from the mediacontroller because I found it the most visually appealing.
Font size is increased, making it more of a heading instead of a lonely text label, and more importantly I made label positioning consistent so when switching between applets the labels are all in the same exact spot.
See https://www.youtube.com/watch?v=1XoommwAiWc for this patch in action.
We should probably unify the notation as well. Device notifier uses a short sentence with Title Capitalization, notifications use a short sentence with a full stop at the end, and mediacontroller uses a long sentence.
Diffs
-----
applets/devicenotifier/package/contents/ui/FullRepresentation.qml d1da0ca
applets/notifications/package/contents/ui/main.qml fd39c57
Diff: https://git.reviewboard.kde.org/r/119934/diff/
Testing
-------
Device notifier still shows its label, notifications still show their label (not if there are notifications), mediacontroller unchanged.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140825/77728765/attachment.html>
More information about the Plasma-devel
mailing list