Review Request 119721: Don't explicitly set a height on button in notification delegate.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119721/
-----------------------------------------------------------

(Updated Aug. 25, 2014, 2:37 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
-------

Don't explicitly set a height on button in notification delegate.

Setting a random value on a button means that it's smaller than the button wants to be and text falls out. The default is set by the button and is correct.

It's not up to the controls to handle being resized; it'd be like complaining at LineEdit if you set the height to 2px tall and you can't read the text.


Diffs
-----

  applets/notifications/package/contents/ui/NotificationPopup.qml 489fbd1 

Diff: https://git.reviewboard.kde.org/r/119721/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140825/36277d76/attachment-0001.html>