Review Request 119797: Show warning in lockscreen when capslock is enabled

[David Edmundson]

> On Aug. 25, 2014, 2:04 p.m., Kai Uwe Broulik wrote:
> > lookandfeel/contents/lockscreen/LockScreen.qml, line 178
> > <https://git.reviewboard.kde.org/r/119797/diff/5/?file=307555#file307555line178>
> >
> >     Does that work? Shouldn't it be dataChanged() ?

both work, this calls the slot, yours would emit the signal which would call the slot.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119797/#review65208
-----------------------------------------------------------


On Aug. 25, 2014, 1:39 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119797/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 1:39 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd 
>   lookandfeel/contents/components/UserSelect.qml 7b605b1 
>   lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 
>   ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 
> 
> Diff: https://git.reviewboard.kde.org/r/119797/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140825/be91a555/attachment-0001.html>