Review Request 119797: Show warning in lockscreen when capslock is enabled

Dan Vrátil dvratil at redhat.com
Mon Aug 25 13:39:58 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119797/
-----------------------------------------------------------

(Updated Aug. 25, 2014, 3:39 p.m.)


Review request for Plasma.


Changes
-------

Lukas Tinkl found a nice way to get Caps Lock status and changes from the KeyState DataEngine, so the patch now makes use of the DataEngine and removes the X11-dependent CapsLock status detection from greeterapp.cpp


Repository: plasma-workspace


Description
-------

This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker.


Diffs (updated)
-----

  ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd 
  lookandfeel/contents/components/UserSelect.qml 7b605b1 
  lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 
  ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 

Diff: https://git.reviewboard.kde.org/r/119797/diff/


Testing
-------


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140825/3695818a/attachment-0001.html>


More information about the Plasma-devel mailing list