Review Request 119866: Thumbnails in Klipper

[Thomas Pfeiffer]

> On Aug. 21, 2014, 5:39 a.m., Martin Gräßlin wrote:
> > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62
> > <https://git.reviewboard.kde.org/r/119866/diff/1/?file=306729#file306729line62>
> >
> >     what happens if you copy a normal http:// url? Is it still shown?
> 
> Sebastian Kügler wrote:
>     No, we're showing the url text in this case. 
>     
>     We *could* make it smarter and run the text through QUrl::isValid(), and then switch the type (though with our current rendering, that would probably be less descriptive than just showing the URL text).
> 
> Martin Gräßlin wrote:
>     that's fine, I was just afraid that switching the check, could have broken it.
>     
>     I don't think it's a very good idea to download the URL - it's one of the things which can get embarrassing if one copies a tiny url ;-)
> 
> Thomas Pfeiffer wrote:
>     Couldn't it also open up an attack vector if someone prepares a site with malicious content and gets users to select a link to it (without even making them click the link)?
> 
> Sebastian Kügler wrote:
>     Not on its own, one would need another broken or leaky component for it to be exploitable. It may be a privacy problem, since the downloading of a URL leaves traces. Fairly remote, but some people might care.
>     
>     IOW: let's just drop the idea and leave it to Unity ;)
> 
> Thomas Pfeiffer wrote:
>     For the privacy-cautious, an option to turn off automatic download would probably be enough.
>     The security concern would be more problematic, but if you say that Klipper alone would not pose a security thread (so we'd avoid situations like Outlook Express automatically running malicious code in emails back in the day), then that shouldn't be a problem.
> 
> Thomas Pfeiffer wrote:
>     (sorry, confusing typo: security thread => security threat)
> 
> Sebastian Kügler wrote:
>     An option to turn off automatic downloading would mean that 99.9% would not switch it off (guess-based stats FTW! ;)), changing almost nothing about the implications.
>     
>     The preview itself would not be very accurate, though, since rendering of a webpage, for example, highly depends on things inside the browser (font settings, javascript / flash / fooplugin on/off, adblock, etc.) and the website itself (mobile vs. desktop site, cookies on/off, https?, is the user logged in?, etc). I don't think a URL preview would offer too much value, besides that it's quite heavy to implement (downloading a webpage often involves hundreds of individual http requests).
> 
> Martin Gräßlin wrote:
>     just to make it clear again: I asked because I was afraid that the change would start downloading and rendering a preview. I do not want to have a preview for an external URL and I would argument very strongly against a change to do so.

Okay, no URL previews, then, fine with me, case closed :)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119866/#review64951
-----------------------------------------------------------


On Aug. 22, 2014, 2:33 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119866/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2014, 2:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch paints previews of copied images, instead of displaying the urls in plain text.
> 
> The display is limited to 4 images right now. The painting of the delegates is in line with the recommendations from the HIG at https://techbase.kde.org/Projects/Usability/HIG/Layout/Image
> 
> It has a few rough edges:
> - not all images get thumbnails -- need to investigate why
> - vertical alignment throughout the list is quite bad, this is the case already, I will fix that separately
> - I want to add an indicator that it's more than 4 files (if applicable), working on that still
> - When no preview is loaded, it should show an icon, almost done, with some fixes
> 
> I'd like some feedback on the code, so that with the remaining issues fixed, it can get in.
> 
> 
> Diffs
> -----
> 
>   applets/clipboard/contents/ui/ClipboardItemDelegate.qml 8eecb80 
>   applets/clipboard/contents/ui/Menu.qml e6821c3 
>   applets/clipboard/contents/ui/clipboard.qml ac784d2 
>   klipper/CMakeLists.txt 660b0d1 
>   klipper/clipboardjob.h b4f5284 
>   klipper/clipboardjob.cpp d84d014 
>   klipper/historyurlitem.cpp fb2a766 
>   klipper/org.kde.plasma.clipboard.operations 813aafa 
> 
> Diff: https://git.reviewboard.kde.org/r/119866/diff/
> 
> 
> Testing
> -------
> 
> Copied images and files in Dolphin, see them showing up in Klipper. Made sure that the previews are only loaded when needed, so no additional memory taken when the systray / klipper popup is not open.
> 
> 
> File Attachments
> ----------------
> 
> Before
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/ebdde483-136e-44da-8735-f98ba88485a9__klipper-before.png
> Klipper with thumbnails
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/65749cc3-3fed-4c9b-9a28-b9791b8e93d8__klipper-thumbnails.png
> Klipper with thumbnails 2nd version
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/4fb72495-0781-4535-8de8-5266652b467a__klipper-after.png
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140825/91cc8a18/attachment-0001.html>