Review Request 119885: Use CMAKE_INSTALL_FULL_BINDIR in plasma.desktop
Dan Vrátil
dvratil at redhat.com
Mon Aug 25 12:28:54 UTC 2014
> On Aug. 25, 2014, 1:24 a.m., Aleix Pol Gonzalez wrote:
> > plasma.desktop.cmake, line 5
> > <https://git.reviewboard.kde.org/r/119885/diff/1/?file=306866#file306866line5>
> >
> > The TryExec is wrong now? :P
Oooops, fixed now. Thanks!
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119885/#review65163
-----------------------------------------------------------
On Aug. 21, 2014, 9:11 p.m., Dan Vrátil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119885/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2014, 9:11 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Prevents ending up with /usr//usr/bin/startkde in plasma.desktop when CMAKE_INSTALL_BINDIR is absolute. It's already used in startkde, so I think it makes sense to use it here too.
>
>
> Diffs
> -----
>
> plasma.desktop.cmake 81ca9a7
>
> Diff: https://git.reviewboard.kde.org/r/119885/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Vrátil
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140825/f88c58f5/attachment.html>
More information about the Plasma-devel
mailing list