Review Request 119920: Restore original checkbox and radio button size

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119920/#review65162
-----------------------------------------------------------



src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml
<https://git.reviewboard.kde.org/r/119920/#comment45511>

    int gridUnit = QFontMetrics(QGuiApplication::font()).boundingRect("M").height();;
    
    so units.gridUnit should be the same as the theme.mSize(theme.defaultFont).height already.
    
    it's /should/ just the margins that need adding to make it consistent.
    
    If that's not the case it means there's something bigger we need to fix in units.


- David Edmundson


On Aug. 24, 2014, 1:54 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119920/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2014, 1:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This patch restores the original checkbox and radio button size calculation as it was before the migration to QtQuick Controls.
> 
> On one hand the newer, smaller one size-wise looks closer to the one used in Widget/Desktop-style apps but eg. battery monitor looks weird with the smaller one.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml d9dc9fd 
>   src/declarativeimports/plasmacomponents/qml/styles/RadioButtonStyle.qml 6d06f01 
> 
> Diff: https://git.reviewboard.kde.org/r/119920/diff/
> 
> 
> Testing
> -------
> 
> CheckBox looks like it did before, did not test Radio Button, in Radio Button it also does away with the hardcoded 6px margin used previously.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140824/33a96349/attachment.html>