Review Request 118406: Notify the user if the location containing the media is inaccessible.

R.Harish Navnit harishnavnit at gmail.com
Sun Aug 24 13:14:22 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118406/
-----------------------------------------------------------

(Updated Aug. 24, 2014, 1:14 p.m.)


Review request for Plasma, Shantanu Tushar and Sinny Kumari.


Changes
-------

After discussions with Shantanu, it was decided that it would be too much complication for a rare case, to implement skipping of media in backward direction. This patch just skips to the next media if the media requested is inaccessible. 


Bugs: 333764
    http://bugs.kde.org/show_bug.cgi?id=333764


Repository: plasma-mediacenter


Description
-------

If a media(in a playlist) is located in an inaccessible location, then the user is notified about the same. 


Diffs (updated)
-----

  mediaelements/mediaplayer/MediaPlayer.qml 98f1d2c733e272ad9941264b99f25fd952edcbec 
  shells/newshell/package/contents/ui/mediacenter.qml 394f820445b2b6896f6540a5d35cb55edfb2f139 

Diff: https://git.reviewboard.kde.org/r/118406/diff/


Testing
-------

1. Load media to a playlist.
2. Unmount the device containing media.
3. Check if the user is notified of the location being inaccessible
   --yes, the user is notified
4. Mount the device containing media and play a media from playlist.
   -- The media plays properly.


File Attachments
----------------

wihtout_i18n.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/06/05/3dc148a5-c4da-4d27-a713-e63922cbcef8__wihtout_i18n.png


Thanks,

R.Harish  Navnit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140824/f12c0821/attachment.html>


More information about the Plasma-devel mailing list