Review Request 119916: Make the notification popup higher when 3 actions are present

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119916/#review65112
-----------------------------------------------------------



applets/notifications/package/contents/ui/NotificationPopup.qml
<https://git.reviewboard.kde.org/r/119916/#comment45489>

    Why not make it take into account the button actual size? Such as Math.max(5 * units.gridUnit, totalHeightOfTheButtonsWithSpacing)



applets/notifications/plugin/notificationshelper.cpp
<https://git.reviewboard.kde.org/r/119916/#comment45490>

    Remove the "more", it's already graded. "separately"


- Kai Uwe Broulik


On Aug. 23, 2014, 11:19 nachm., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119916/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2014, 11:19 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Since the port of the Button component to QQC Button, the button height cannot be set anymore, therefore the height of the popup now needs to be higher when there are three actions.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/NotificationPopup.qml 489fbd1 
>   applets/notifications/plugin/notificationshelper.cpp 783c0e4 
> 
> Diff: https://git.reviewboard.kde.org/r/119916/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/23/826a7f99-31f9-47e6-ba58-82ba523f5728__notifications-3actions.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140824/3a0e97db/attachment.html>