Review Request 119902: Port calculator to GridLayout and use row/colSpan

Bhushan Shah bhush94 at gmail.com
Fri Aug 22 14:36:09 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119902/#review65060
-----------------------------------------------------------

Ship it!


Ship It!

- Bhushan Shah


On Aug. 22, 2014, 7:54 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119902/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2014, 7:54 p.m.)
> 
> 
> Review request for Plasma and Bhushan Shah.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Port calculator to GridLayout and use row/colSpan
> 
> Instead of placeholders, removes custom buttonWidth/height calculation
> 
> 
> Diffs
> -----
> 
>   applets/calculator/package/contents/ui/calculator.qml 3055d3e 
> 
> Diff: https://git.reviewboard.kde.org/r/119902/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140822/a6459f3c/attachment.html>


More information about the Plasma-devel mailing list