Review Request 119860: hints to disable background in dialogs

[Marco Martin]

> On Aug. 21, 2014, 1:12 p.m., David Edmundson wrote:
> > src/plasmaquick/dialog.cpp, line 195
> > <https://git.reviewboard.kde.org/r/119860/diff/2/?file=306860#file306860line195>
> >
> >     we're now doing this on every resize, is this a big overhead?

was already there, but apparently was useless


> On Aug. 21, 2014, 1:12 p.m., David Edmundson wrote:
> > src/plasmaquick/dialog.cpp, line 198
> > <https://git.reviewboard.kde.org/r/119860/diff/2/?file=306860#file306860line198>
> >
> >     this is new.

if the background gets enabled or disabled, the inputshape needs to be enabled or disables accordingly


> On Aug. 21, 2014, 1:12 p.m., David Edmundson wrote:
> > src/plasmaquick/dialog.cpp, line 934
> > <https://git.reviewboard.kde.org/r/119860/diff/2/?file=306860#file306860line934>
> >
> >     only do this if we're in componentCompleted

since this property can be changed at runtime, the background needs to be disabled or enabled at runtime as well


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119860/#review64978
-----------------------------------------------------------


On Aug. 21, 2014, 1:03 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119860/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2014, 1:03 p.m.)
> 
> 
> Review request for Plasma and Pier Luigi Fiorini.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> add the possibility to not have backgrounds in dialogs.
> one ting i don't like that much is the fact that it pretty much forces to either having perfect rectangular windows or to have composite for correct looks, but that will be probably less important.
> One thing that should be paid attention is that with no background is not supported the kwin-side shadow, as well no blur as well, since we don't have info for the shape, tough if needed in the future blur with just the full rectangular shape may be added as a new flag in backgroundhints, those possibilities of expansion is one reason it's an enum not a bool.
> 
> The use case for it is for custom dialogs in Maui, and since Dialog already manages the million edge cases of sizing and positioning that we had to fix, the least painful route i think is to use them with the background disabled.
> the framesvgitem is still there, but not having a svg loaded shouldn't take memory for images neither in heap nor gpu (probably would be good as well to set the flag itemhasnocontents on framesvgitem if imagepath is invalid, to be really sure it will never even try to upload any texture)
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.h 27b3b5a 
>   src/plasmaquick/dialog.cpp 64fb4a9 
> 
> Diff: https://git.reviewboard.kde.org/r/119860/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140821/56b200fe/attachment.html>