Review Request 119872: AppletInterface::init should set focus not forceActiveFocus

Frederik Gladhorn gladhorn at kde.org
Thu Aug 21 08:02:57 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119872/
-----------------------------------------------------------

(Updated Aug. 21, 2014, 8:02 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
-------

Setting the focus is a good thing, the problem with forceActiveFocus is
that it will not allow any child to receive the actual focus, instead
the focus is forced on to the root element of the applet which may not
be desired.
When for example trying to improve keyboard focus behavior of KickOff
without this patch I cannot get the initial focus on the list of
favorites since it gets reset after the applet is created.


Diffs
-----

  src/scriptengines/qml/plasmoid/appletinterface.cpp fd92f46 

Diff: https://git.reviewboard.kde.org/r/119872/diff/


Testing
-------

Made accessibility focus handling work in KickOff. Patches for KickOff still need cleanup.


Thanks,

Frederik Gladhorn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140821/414358bc/attachment.html>


More information about the Plasma-devel mailing list