Review Request 119874: Make Kicker's root item a FocusScope
Eike Hein
hein at kde.org
Wed Aug 20 21:34:19 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119874/#review64947
-----------------------------------------------------------
Ship it!
Ship It!
- Eike Hein
On Aug. 20, 2014, 9:27 p.m., Frederik Gladhorn wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119874/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2014, 9:27 p.m.)
>
>
> Review request for Plasma and Eike Hein.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> When opening kicker with a shortcut (e.g. alt-f1) it would not have any
> focus. This is because the root item would get the focus but not "pass it
> on" to any child below itself.
> Making the root item a FocusScope means that when it receives focus the
> focus moves to the line edit since that one has focus: true.
>
>
> Diffs
> -----
>
> applets/kicker/package/contents/ui/FullRepresentation.qml 1a1e845
>
> Diff: https://git.reviewboard.kde.org/r/119874/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Frederik Gladhorn
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140820/677bca29/attachment.html>
More information about the Plasma-devel
mailing list