Review Request 119841: standardise the way version numbers are set in plasma

[Jonathan Riddell]

> On Aug. 19, 2014, 11:10 a.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 5
> > <https://git.reviewboard.kde.org/r/119841/diff/1/?file=306387#file306387line5>
> >
> >     Why do you need to have major, minor and patch separately?
> >     
> >     Also we can probably use the project(VERSION) argument for this, it would end up something like:
> >     project(systemsettings VERSION 5.95.0)
> >     
> >     without any weird set calls.

Several parts of plasma set major, minor and patch separately (mostly to use the major as soversion) and I'd like it to be done the same way in all of them.

project with VERSION seems to be only in cmake 3, most distros still use cmake 2.8


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119841/#review64833
-----------------------------------------------------------


On Aug. 19, 2014, 11:06 a.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119841/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 11:06 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> -------
> 
> standardise the way version numbers are set in plasma
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5c09e134f02f95bf191e36209e60bd9c6b13a26c 
>   app/CMakeLists.txt 05fe8e3f1b89034f6c55455b080b652ab30f01e3 
>   app/main.cpp 46ec0bf4a217a6b94410d2192609f0444c82ca17 
> 
> Diff: https://git.reviewboard.kde.org/r/119841/diff/
> 
> 
> Testing
> -------
> 
> compiled and ran systemsettings5 --version
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140819/e87a6956/attachment.html>