Review Request 119794: Add button to change keyboard layout in the lockscreen

[Dan Vrátil]

> On Aug. 16, 2014, 1:58 p.m., Emmanuel Pescosta wrote:
> > lookandfeel/contents/components/KeyboardLayout.qml, line 28
> > <https://git.reviewboard.kde.org/r/119794/diff/2/?file=305631#file305631line28>
> >
> >     really?! ;)

Ooops, copy paste :)


> On Aug. 16, 2014, 1:58 p.m., Emmanuel Pescosta wrote:
> > lookandfeel/contents/components/KeyboardLayout.qml, line 47
> > <https://git.reviewboard.kde.org/r/119794/diff/2/?file=305631#file305631line47>
> >
> >     Maybe a simple modulo operation instead of this check?

This seems a bit easier to understand and a is I'd say more common solution for "is this the last item in the list" check


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119794/#review64630
-----------------------------------------------------------


On Aug. 14, 2014, 11:40 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119794/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 11:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This adds a button that allows toggling keyboard layout from the lockscreen. It talks and listens directly to the KDED's keyboard module.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 7ac1846 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 3af10ef 
>   ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION 
>   ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION 
>   lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION 
>   lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 
> 
> Diff: https://git.reviewboard.kde.org/r/119794/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> 
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/14/a96e6542-b7c8-4945-ada4-e97873e9b9b0__scrlocker.png
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140818/fae51f37/attachment-0001.html>