Review Request 119797: Show warning in lockscreen when capslock is enabled

[Dan Vrátil]

> On Aug. 15, 2014, 10:34 a.m., Kai Uwe Broulik wrote:
> > lookandfeel/contents/lockscreen/LockScreen.qml, line 63
> > <https://git.reviewboard.kde.org/r/119797/diff/2/?file=305636#file305636line63>
> >
> >     units.largeSpacing * 15
> >     
> >     Nonetheless, that looks wrong to me, don't we have gridUnit for stuff like that?
> 
> Dan Vrátil wrote:
>     This actually represents the height of the actual content block - I'm not sure we can/want to use some generic value for that.
>     
>     I think in ideal case the height of the element should be based on total height of the elements it contains - I'm not sure why this is not the case but I'll try to do it that way first.

Hmm, looks like StackView automatically expands to full size unless height is explicitly set. Any ideas are welcomed :)


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119797/#review64587
-----------------------------------------------------------


On Aug. 18, 2014, 4:19 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119797/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2014, 4:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker.
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 
>   lookandfeel/contents/components/UserSelect.qml 7b605b1 
> 
> Diff: https://git.reviewboard.kde.org/r/119797/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140818/9a90f242/attachment.html>