Review Request 119817: Display notification popup at the top for top panel

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119817/#review64740
-----------------------------------------------------------

Ship it!


Pretty cool, thanks!

- Martin Klapetek


On Aug. 17, 2014, 11:59 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119817/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2014, 11:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch makes the notification popups appear at the top when used from a top panel
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/Notifications.qml 9b492d9 
>   applets/notifications/plugin/notificationshelper.h 0476952 
>   applets/notifications/plugin/notificationshelper.cpp 783c0e4 
> 
> Diff: https://git.reviewboard.kde.org/r/119817/diff/
> 
> 
> Testing
> -------
> 
> Works as expected, when panel is moved around, popups re-position themselves if needed.
> 
> 
> File Attachments
> ----------------
> 
> Notifications at the top
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/17/97aea6b9-b71f-4787-9a9b-574b5c6e5bc4__toppopup.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140818/4c906501/attachment.html>