Review Request 119813: Show activity-linked files in folder view option

Ivan Čukić ivan.cukic at kde.org
Mon Aug 18 10:29:19 UTC 2014



> On Aug. 17, 2014, 2:36 p.m., Eike Hein wrote:
> > Looks good, but: I'm aware of at least one downstream that would like to hide activities support from plasmashell for complexity reasons. Is there a way to disable activities support, and does it have an API we could use to conditionally hide the option in Folder?
> 
> Ivan Čukić wrote:
>     There is no way to disable activities. At least, not a supported way.
>     
>     I *do* sometimes test a few things without the activity manager running, but it was decided at one point (a long time ago) that we will not be supporting that setup in any manner.
>     
>     The only component that is always guaranteed to work without activities is kwin, because it needs to work with other environments beside Plasma.
>     
>     From my point of view, if a distribution wants something like that, they need to be prepared to maintain their own patches which I don't think is very manageable in the long-run.
>     
>     
>     * interestingly enough, there still is a hidden checkbox in the activities kcm for disabling the system, but it was voted out as soon as I created it. It has absolutely no effect now.
> 
> Eike Hein wrote:
>     > From my point of view, if a distribution wants something like that, they need to be prepared to maintain their own patches which I don't think is very manageable in the long-run.
>     
>     I agree, having them fork the code downstream all over the place is pretty ugly. So the only recourse is to leave this patch out for now then.

The problem with leaving the patch out is that it is a regression compared to 4.1x (pre-baloo).

And if we do it like this, no new feature (at least, activity-related) will ever get in.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119813/#review64674
-----------------------------------------------------------


On Aug. 17, 2014, 2:32 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119813/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2014, 2:32 p.m.)
> 
> 
> Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This is port of the feature that the folder view had before baloo replaced nepomuk - the configuration option to show the files that are linked to the current activity (activities:/current/).
> 
> It requires the latest master of kactivities which ship with the new kio implementation.
> 
> 
> Diffs
> -----
> 
>   containments/folder/package/contents/ui/ConfigLocation.qml dc97e81 
> 
> Diff: https://git.reviewboard.kde.org/r/119813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140818/0032aeb5/attachment.html>


More information about the Plasma-devel mailing list