Review Request 119799: New activities linking file item plugin

[Ivan Čukić]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119799/
-----------------------------------------------------------

(Updated Aug. 15, 2014, 8:42 a.m.)


Review request for Dolphin, Plasma and Frank Reininghaus.


Changes
-------

Cleaned up the diff, and added MODULE to the add_library in CMakeLists.txt


Repository: kactivities


Description
-------

New version of the file item plugin for the post nepomuk era and kf5.

The behaviour is changed compared to the previous one:
- At first, it shows a submenu (named 'Activities') that contains the 'Loading...' text
- When the popup is requested to be shown (hovered signal of the root action) it asynchronously loads the sub-actions.

It is much faster than the nepomuk-based one, and it does not  display the 'Loading...' item to the user at all.


Diffs (updated)
-----

  src/workspace/CMakeLists.txt bd4e636 
  src/workspace/fileitemplugin/CMakeLists.txt d835aec 
  src/workspace/fileitemplugin/FileItemLinkingPlugin.h ef7ad3b 
  src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp 5bcc141 
  src/workspace/fileitemplugin/FileItemLinkingPlugin_p.h 6fb9b13 

Diff: https://git.reviewboard.kde.org/r/119799/diff/


Testing
-------

Tested also with artificial slowing down with sleeps.
Tested also when the activity manager is not running.


Thanks,

Ivan Čukić

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140815/033be409/attachment.html>