Review Request 119797: Show warning in lockscreen when capslock is enabled
Kai Uwe Broulik
kde at privat.broulik.de
Fri Aug 15 08:34:33 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119797/#review64587
-----------------------------------------------------------
lookandfeel/contents/lockscreen/LockScreen.qml
<https://git.reviewboard.kde.org/r/119797/#comment45140>
You generally don't need semicolons after QML properties
lookandfeel/contents/lockscreen/LockScreen.qml
<https://git.reviewboard.kde.org/r/119797/#comment45139>
units.largeSpacing * 15
Nonetheless, that looks wrong to me, don't we have gridUnit for stuff like that?
lookandfeel/contents/lockscreen/LockScreen.qml
<https://git.reviewboard.kde.org/r/119797/#comment45138>
Swap those, ie. empty line below
lookandfeel/contents/lockscreen/LockScreen.qml
<https://git.reviewboard.kde.org/r/119797/#comment45137>
So you tell it to be centered horizontally, and wrap, but a maximum of one line is allowed? This will have no effect whatsoever since the label will just grow outside horizontally because it has no width/side anchors set.
- Kai Uwe Broulik
On Aug. 14, 2014, 10:25 nachm., Dan Vrátil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119797/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2014, 10:25 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker.
>
>
> Diffs
> -----
>
> lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9
> lookandfeel/contents/components/UserSelect.qml 7b605b1
>
> Diff: https://git.reviewboard.kde.org/r/119797/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Vrátil
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140815/0a03daba/attachment.html>
More information about the Plasma-devel
mailing list