Review Request 119758: Add option to DigitalClock applet to show date

Dan Vrátil dvratil at redhat.com
Thu Aug 14 18:20:31 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119758/
-----------------------------------------------------------

(Updated Aug. 14, 2014, 8:20 p.m.)


Review request for Plasma.


Changes
-------

Added code to force-recalculate size of the applet when date changes, because the date string length might change (shorter/longer day or month name)


Bugs: 335006
    https://bugs.kde.org/show_bug.cgi?id=335006


Repository: plasma-workspace


Description
-------

This patch adds option to show date in the DigitalClock applet, something I was very much missing after switching to Plasma 5 :-)

Similary to the KDE 4 applet, users can choose from long, short and narrow date formats.


Diffs (updated)
-----

  applets/digital-clock/package/contents/config/main.xml 74ac640 
  applets/digital-clock/package/contents/ui/DigitalClock.qml 20babc3 
  applets/digital-clock/package/contents/ui/configAppearance.qml ab67e14 

Diff: https://git.reviewboard.kde.org/r/119758/diff/


Testing
-------


File Attachments
----------------

In vertical panel
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/7e08759e-18a2-46b7-92f7-a3bff6946cf4__clock1.png
In horizontal panel
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/b55b1ab2-98fc-4ab8-a64e-c4635574d3e1__clock3.png
Settings dialog
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/7c309d90-6b4b-42a2-907e-98c0b47389e8__clock2.png


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140814/995919dd/attachment.html>


More information about the Plasma-devel mailing list