Review Request 119748: Properly align KickoffButtons to center when in vertical mode

Dan Vrátil dvratil at redhat.com
Tue Aug 12 23:43:26 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119748/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-desktop


Description
-------

The labels in Kickoff are misaligned when Kickoff is in vertical mode (see the first screenshot). This patch fixes it by making sure the KickoffButton is always as wide as the parent container, even when the label string is shorter, so that the text is always centered.


Diffs
-----

  applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 

Diff: https://git.reviewboard.kde.org/r/119748/diff/


Testing
-------


File Attachments
----------------

Before
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png
After
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/dd8b7151-2ab1-43de-acaf-b010d57e3efb__kickoff-after.png


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140812/3706ff21/attachment.html>


More information about the Plasma-devel mailing list