Review Request 119739: Don't hardcode applet configuration sidebar size

Kai Uwe Broulik kde at privat.broulik.de
Tue Aug 12 18:32:39 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119739/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-desktop


Description
-------

The sidebar in the applet configuration which tries to mimic the sidebar in traditional KCMs is hardcoded to 100px resulting in cramped text on my machine.

The grid * 7 is completely arbitrary and I don't like it but I have no idea what heuristics Qt uses to determin the size of that panel.


Diffs
-----

  desktoppackage/contents/configuration/AppletConfiguration.qml 546b8db 

Diff: https://git.reviewboard.kde.org/r/119739/diff/


Testing
-------

It looks fine on my machine (fonts at 180dpi) but somebody with an ordinary display should definitely verify that.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140812/ae5d66bd/attachment.html>


More information about the Plasma-devel mailing list