Review Request 119669: Fix broken creation of kstartupconfigfiles

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119669/
-----------------------------------------------------------

(Updated Aug. 12, 2014, 9:42 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
-------

Fix broken creation of kstartupconfigfiles

kstartupconfigfiles contains a list of files to compare mtimes on to see
if we need to rebuild kstartupconfig. This wasn't being created
correctly so we failed to rebuild if any configs updated.

This was broken in Qt5 porting:
-        const QStringList dirs =
KGlobal::dirs()->kfsstnd_prefixes().split( KPATH_SEPARATOR, QString::SkipEmptyParts);
+        const QStringList dirs =
QStandardPaths::standardLocations(QStandardPaths::GenericDataLocation);


Diffs
-----

  startkde/kstartupconfig/kdostartupconfig.cpp af6062c 

Diff: https://git.reviewboard.kde.org/r/119669/diff/


Testing
-------

Checked output of kstartupconfigfiles was sane.
Updated ksplashrc, ran kstartupconfig5 (NOT kdostartupconfig5) checked kstartupconfig was regenerated.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140812/3813824f/attachment-0001.html>