Use of KDirWatch

[Aleix Pol]

On Mon, Aug 11, 2014 at 6:09 PM, Marco Martin <notmart at gmail.com> wrote:

> On Friday 08 August 2014, Eike Hein wrote:
> > Hi,
> >
> > many things in Plasma use KDirWatch to keep an eye on changes,
> > e.g. the theming and look-and-feel systems, and they usually
> > go through the KDirWatch::self() instance.
> >
> > The gotcha with using the shared instance is that slots
> > connected to its signals then have to make sure to discard
> > notifications about files they don't actually care about but
> > *others* do, and Plasma code currently isn't rigorous on that.
> > While the theming code is smart about it, I just spotted a
> > slot in the look-and-feel code that isn't.
>
> fixed that one
>
> --
> Marco Martin
>
>
Should we maybe agree that KDirWatch::self() is harmful in the context of
plasma?

Aleix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140812/f8088a7d/attachment-0001.html>