Review Request 119720: Streamline device notifier

[Marco Martin]

> On Ago. 11, 2014, 6:36 p.m., Martin Klapetek wrote:
> > Just a note - if you put this applet on the desktop, it won't have the big headline. I've asked a month ago if it should have the headline on the desktop too but I was told no, so maybe we want some "if (formFactor == desktop)" in the code..?

when there is content, there isn't much value over repeating what it is. when the applet is empty an alternative text may be handy.
(almost tempted to add api in plasmoid for that, but not sure how much would be actually used)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119720/#review64295
-----------------------------------------------------------


On Ago. 11, 2014, 6:25 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119720/
> -----------------------------------------------------------
> 
> (Updated Ago. 11, 2014, 6:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This streamlines the device notifier plasmoid.
> 
> - Remove redundand "Available devices" label and only show "No devices available" if there aren't any (Maybe rename "Device Notifier" to something less geeky, that replaces the former heading?)
> - Use the same Heading as the notifications for the sections
> 
> 
> Diffs
> -----
> 
>   applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9070788 
> 
> Diff: https://git.reviewboard.kde.org/r/119720/diff/
> 
> 
> Testing
> -------
> 
> Yup.
> 
> 
> File Attachments
> ----------------
> 
> Device Notifier (before)
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/11/c44f1937-d712-4516-b0e7-a7177ef3715b__devicenotifyold.png
> Device Notifier (after)
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/11/53c802f5-9d1a-4176-8025-e3b3dab45d93__devicenotifynew.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140811/0324f924/attachment.html>