Review Request 119719: Streamline notifications plasmoid

[Martin Klapetek]

> On Aug. 11, 2014, 8:37 p.m., Martin Klapetek wrote:
> > > I have no idea what's wrong with the action button.
> > 
> > This broke since the port to QtQuick Controls' Button, not sure what to do about it tho
> 
> Kai Uwe Broulik wrote:
>     Well, clearly the button's label does not honor the button's custom height as set by the NotificationsDelegate, as can be easily seen in [1].
>     
>     [1] http://wstaw.org/w/2Thp/

Right, that seems to be the QQC Button limitation. I haven't checked but I think it gets the default height from the platform style hint and then just ignores the height as it expects all the buttons to have the same height on the given platform (which actually makes sense...and also raises some questions regarding the notification buttons ;)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119719/#review64296
-----------------------------------------------------------


On Aug. 11, 2014, 8:19 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119719/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 8:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This streamlines the notification plasmoid a bit.
> 
> - Get rid of hardcoded sizes (was quite cramped here)
> 
> - Get rid of huge "Transfers" heading. It was the same size as the systray title and added little value
> 
> I have no idea what's wrong with the action button.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/Jobs.qml 2f5a88e 
>   applets/notifications/package/contents/ui/NotificationDelegate.qml 0b97d77 
> 
> Diff: https://git.reviewboard.kde.org/r/119719/diff/
> 
> 
> Testing
> -------
> 
> Yup.
> 
> 
> File Attachments
> ----------------
> 
> Notifications (before)
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/11/da7f1f4e-df8f-4eda-aca8-1c4fcc6fdeda__notifyold.png
> Notifications (after)
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/11/1064cc3d-8ae0-4267-ae6e-1643f8a0a23a__notifynew.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140811/7a2e469d/attachment-0001.html>