Review Request 119683: [Idea] Rotate popup arrow animated instead of changing element

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119683/#review64279
-----------------------------------------------------------


Almost good to go..
I wonder if the code would be slightly more comact using states and transitions instead?


applets/systemtray/package/contents/ui/CompactRepresentation.qml
<https://git.reviewboard.kde.org/r/119683/#comment44927>

    RotationAnimation ?



applets/systemtray/package/contents/ui/CompactRepresentation.qml
<https://git.reviewboard.kde.org/r/119683/#comment44928>

    RotationAnimation ?


- Marco Martin


On Ago. 11, 2014, 4:33 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119683/
> -----------------------------------------------------------
> 
> (Updated Ago. 11, 2014, 4:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is a simple patch which makes the popup arrow rotate in an animated way when opening/closing the popup instead of switching elements.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/ui/CompactRepresentation.qml 579dde6 
> 
> Diff: https://git.reviewboard.kde.org/r/119683/diff/
> 
> 
> Testing
> -------
> 
> Works, the arrow always rotates facing the system tray icons, ie. clockwise in a top panel and counter-clockwise in a bottom panel.
> 
> It only uses arrow-top so might give issues with themes that have different arrow looks(?)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140811/ec365bc7/attachment-0001.html>