Review Request 119670: Initial port of systemloadviewer

[Martin Yrjölä]

> On Aug. 8, 2014, 4:49 p.m., David Edmundson wrote:
> > applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml, line 29
> > <https://git.reviewboard.kde.org/r/119670/diff/1/?file=302571#file302571line29>
> >
> >     I /think/ we can just set a preferred representation, or a switching size of 0,0
> >     Otherwise we're potentially creating two instances of exactly the same component which would be a bit rubbish.
> 
> Marco Martin wrote:
>     those cases are what preferredRepresentation is for, I would go for that

Fixed in revision 2.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119670/#review64077
-----------------------------------------------------------


On Aug. 8, 2014, 4:24 p.m., Martin Yrjölä wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119670/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2014, 4:24 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Initial port of systemloadviewer
> 
> This only includes basic functionality. I'm planning on adding at least:
> - Color settings
> - Gradients!
> - Horizontal bar support
> 
> 
> Diffs
> -----
> 
>   applets/systemloadviewer/TODO 210dcd76f02b2a8f62e2e7339d089c545a4fb112 
>   applets/systemloadviewer/coloursconfig.ui 70a08afbaa204bb78865a545965210f3e2dfe42a 
>   applets/systemloadviewer/generalconfig.ui 2ae6d6540a12203e73bab5ca930da751f94bde22 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml PRE-CREATION 
>   applets/systemloadviewer/plasma-applet-systemloadviewer.desktop 9324d4216e716b2156f5f084c8b4782a6dd84806 
>   applets/systemloadviewer/systemloadviewer.h 9bbcf2305ef47dd8883600002a9b65954ba65a74 
>   applets/systemloadviewer/systemloadviewer.cpp bff0b34aa2d7a46e8e1fa052bb6008cf52a4497f 
>   applets/CMakeLists.txt 661ecb421419f6cae8551924f107346787740aa9 
>   applets/systemloadviewer/CMakeLists.txt 6de867aa63e5102a5085667f8106ec09da2c4968 
>   applets/systemloadviewer/Messages.sh b95833b3b5cf7865e72ed6b46e8dcd7848c599e1 
> 
> Diff: https://git.reviewboard.kde.org/r/119670/diff/
> 
> 
> Testing
> -------
> 
> ![Screenshot](http://i.imgur.com/lB1d33s.png)
> 
> 
> Thanks,
> 
> Martin Yrjölä
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140809/a03564ad/attachment.html>