Review Request 119651: kactivities: Do not load plugins marked as EnabledByDefault=false.

[Ivan Čukić]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119651/#review64007
-----------------------------------------------------------

Ship it!


Ok for 4.x branch

- Ivan Čukić


On Aug. 7, 2014, 5:26 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119651/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 5:26 p.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Bugs: 305529
>     http://bugs.kde.org/show_bug.cgi?id=305529
> 
> 
> Repository: kactivities
> 
> 
> Description
> -------
> 
> Follow up to dc0fc3f: just setting X-KDE-PluginInfo-EnabledByDefault to
> false in the activity ranking plugin is not enough, as Application will
> still try to load it.
> 
> 
> Diffs
> -----
> 
>   src/service/Application.cpp ac4978b4ee59d45a18687ccdca7c21e6bcd08854 
> 
> Diff: https://git.reviewboard.kde.org/r/119651/diff/
> 
> 
> Testing
> -------
> 
> kactivitymanagerd stops crashing on startup when loading the activity ranking plugin.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140807/ce903f2c/attachment.html>