Review Request 119634: Some CMake fixups for kdeplasma-addons
David Edmundson
david at davidedmundson.co.uk
Wed Aug 6 13:34:37 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119634/#review63919
-----------------------------------------------------------
CMakeLists.txt
<https://git.reviewboard.kde.org/r/119634/#comment44588>
if it's unused, just delete it?
- David Edmundson
On Aug. 6, 2014, 12:59 p.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119634/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 12:59 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> There was a huge amount of Frameworks which wheren't needed. also fixed some deprecation warnings, commented out unused stuff, etc.
>
>
> Diffs
> -----
>
> CMakeLists.txt a3b134d
> dataengines/konsoleprofiles/CMakeLists.txt 1e0a0fc
> runners/converter/CMakeLists.txt f0ee664
> runners/dictionary/CMakeLists.txt e5ff6cd
>
> Diff: https://git.reviewboard.kde.org/r/119634/diff/
>
>
> Testing
> -------
>
> builds
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140806/f9b2b44e/attachment.html>
More information about the Plasma-devel
mailing list