Review Request 119618: add theme selection for screen lockers

[Marco Martin]

> On Aug. 6, 2014, 9:20 a.m., David Edmundson wrote:
> > ksmserver/screenlocker/kcm/package/contents/ui/main.qml, line 115
> > <https://git.reviewboard.kde.org/r/119618/diff/2/?file=296899#file296899line115>
> >
> >     Either we need to set the language domain or use i18nd
> 
> Marco Martin wrote:
>     isn't add_definitions(-DTRANSLATION_DOMAIN=\"screenlocker_kcm\") in the cmake enough?
>     or can be only one domain per process?
> 
> David Edmundson wrote:
>     I don't think so.
>     i18n in C++ (in KF5) is a macro that expands to i18nd(TRANSLATION_DOMAIN, whatever)
>     
>     in QML we're obviously not a macro, so that won't happen, so kdeclarative uses whatever domain it's set to.
> 
> David Edmundson wrote:
>     and kdeclrative::rootcontext.cpp starts with
>     
>     // Undefine this because we don't want our i18n*() method names to be turned into i18nd*()
>     #undef TRANSLATION_DOMAIN

right, kdeclarative is in another library, so TRANSLATION_DOMAIN is obviously different when called from there


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119618/#review63902
-----------------------------------------------------------


On Aug. 6, 2014, 10:39 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119618/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2014, 10:39 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> one thing that was requested a lot as well, is an override on the screen locker package as is done in the splash screen as well (master already supports reading it from config, the kcm to set that was missing tough)
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/kcm/CMakeLists.txt 17e4f70 
>   ksmserver/screenlocker/kcm/kcm.h PRE-CREATION 
>   ksmserver/screenlocker/kcm/kcm.cpp d74ab75 
>   ksmserver/screenlocker/kcm/kcm.ui 1cc2653 
>   ksmserver/screenlocker/kcm/package/contents/ui/main.qml PRE-CREATION 
>   ksmserver/screenlocker/kcm/package/metadata.desktop PRE-CREATION 
>   lookandfeel/contents/lockscreen/screenshot.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119618/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> locker.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/05/1174ed52-d86c-4345-9790-0cb5dd8f75ca__locker.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140806/d9fc5cf0/attachment.html>