Review Request 119618: add theme selection for screen lockers

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119618/#review63902
-----------------------------------------------------------

Ship it!


Looks good.


ksmserver/screenlocker/kcm/package/contents/ui/main.qml
<https://git.reviewboard.kde.org/r/119618/#comment44560>

    Either we need to set the language domain or use i18nd



ksmserver/screenlocker/kcm/package/contents/ui/main.qml
<https://git.reviewboard.kde.org/r/119618/#comment44561>

    Make it 0


- David Edmundson


On Aug. 5, 2014, 4:14 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119618/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 4:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> one thing that was requested a lot as well, is an override on the screen locker package as is done in the splash screen as well (master already supports reading it from config, the kcm to set that was missing tough)
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/kcm/CMakeLists.txt 17e4f70 
>   ksmserver/screenlocker/kcm/kcm.h PRE-CREATION 
>   ksmserver/screenlocker/kcm/kcm.cpp d74ab75 
>   ksmserver/screenlocker/kcm/kcm.ui 1cc2653 
>   ksmserver/screenlocker/kcm/package/contents/ui/main.qml PRE-CREATION 
>   ksmserver/screenlocker/kcm/package/metadata.desktop PRE-CREATION 
>   lookandfeel/contents/lockscreen/screenshot.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119618/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> locker.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/05/1174ed52-d86c-4345-9790-0cb5dd8f75ca__locker.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140806/2c47bc1c/attachment-0001.html>