Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

[Vishesh Handa]

> On Aug. 5, 2014, 2:17 p.m., Vishesh Handa wrote:
> > I think the Baloo repo might a better place for code. It's not really Plasma specific.
> 
> Marco Martin wrote:
>     import org.kde.baloo in the baloo repo with this class and eventually others?
>     would you do it just as an import or accessible also in a c++ library?
>     one thing, before putting out an import that risks to have only one user, would be good to assest what exactly applications that need something like that need (atm mostly plasma mediacenter and jungle i guess? the VDG iirc wanted to design an application kindof a desktop-oriented version of the active file browser, but I guess ideas on that aren't clear yet at all)

Yup. "org.kde.baloo" makes sense. I think just an import makes more sense for now.

Jungle will not be using Baloo like this. We directly use the C++ Query API. I cannot speak about PMC. You might be right about it having only one user. We could say we don't guarantee any kind of stability on the QML parts (for now)


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119617/#review63861
-----------------------------------------------------------


On Aug. 5, 2014, 12:22 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119617/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 12:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mobile
> 
> 
> Description
> -------
> 
> This component allows us to fetch files from the baloo.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e90cec6 
>   components/CMakeLists.txt 536b60e 
>   components/baloodatamodel/CMakeLists.txt PRE-CREATION 
>   components/baloodatamodel/baloodatamodel.h PRE-CREATION 
>   components/baloodatamodel/baloodatamodel.cpp PRE-CREATION 
>   components/baloodatamodel/baloodatamodelplugin.h PRE-CREATION 
>   components/baloodatamodel/baloodatamodelplugin.cpp PRE-CREATION 
>   components/baloodatamodel/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119617/diff/
> 
> 
> Testing
> -------
> 
> Everything works, we can get:
> 
> * the file id
> * the file icon
> * the file url
> * the file text
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140805/f76e7d00/attachment-0001.html>