Review Request 119618: add theme selection for screen lockers

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119618/#review63866
-----------------------------------------------------------



File Attachment: locker.png - locker.png
<https://git.reviewboard.kde.org//r/119618/#fcomment232>

    Do we want a frame round this?
    
    A title of "Lock screen style" might be useful?



ksmserver/screenlocker/kcm/lockermodel.cpp
<https://git.reviewboard.kde.org/r/119618/#comment44537>

    http://qt-project.org/doc/qt-5/qstandarditemmodel.html#setItemRoleNames



ksmserver/screenlocker/kcm/package/contents/ui/main.qml
<https://git.reviewboard.kde.org/r/119618/#comment44535>

    I don't like mixing Plasma controls in desktop stuff, it's very easy to get white text on a white background.
    
    Why do we need this over QtQuickControls.Button?



ksmserver/screenlocker/kcm/package/contents/ui/main.qml
<https://git.reviewboard.kde.org/r/119618/#comment44536>

    what's this for? I assume you're working round something.
    
    (and don't reply here, reply in code comments :) )


- David Edmundson


On Aug. 5, 2014, 3:18 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119618/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 3:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> one thing that was requested a lot as well, is an override on the screen locker package as is done in the splash screen as well (master already supports reading it from config, the kcm to set that was missing tough)
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/lockscreen/screenshot.png PRE-CREATION 
>   ksmserver/screenlocker/kcm/lockermodel.h PRE-CREATION 
>   ksmserver/screenlocker/kcm/lockermodel.cpp PRE-CREATION 
>   ksmserver/screenlocker/kcm/package/contents/ui/main.qml PRE-CREATION 
>   ksmserver/screenlocker/kcm/package/metadata.desktop PRE-CREATION 
>   ksmserver/screenlocker/kcm/CMakeLists.txt 17e4f70 
>   ksmserver/screenlocker/kcm/kcm.cpp d74ab75 
>   ksmserver/screenlocker/kcm/kcm.ui 1cc2653 
> 
> Diff: https://git.reviewboard.kde.org/r/119618/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> locker.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/05/1174ed52-d86c-4345-9790-0cb5dd8f75ca__locker.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140805/efe279f5/attachment-0001.html>