Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

[Marco Martin]

> On Aug. 5, 2014, 12:29 p.m., Marco Martin wrote:
> > components/baloodatamodel/baloodatamodel.cpp, line 116
> > <https://git.reviewboard.kde.org/r/119617/diff/1/?file=296386#file296386line116>
> >
> >     maybe this should be done in a thread?
> 
> Vishesh Handa wrote:
>     I named the method exec so that it was clear it might block for a bit. It does not spawn an event loop internally.
>     
>     Considering that the QML rendering is typically done in another thread anyway maybe this minor block is okay. We will need to evaulate this based on the queries. It might not make sense to always spawn a new thread.
>     
>     We provide a BalooRunnable class if you want to put it in another thread.

ok, so i would leave it as is and eventually use baloorunnable iff users of this will encounter particular performace problems, otherwise KISS


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119617/#review63848
-----------------------------------------------------------


On Aug. 5, 2014, 12:22 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119617/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 12:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mobile
> 
> 
> Description
> -------
> 
> This component allows us to fetch files from the baloo.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e90cec6 
>   components/CMakeLists.txt 536b60e 
>   components/baloodatamodel/CMakeLists.txt PRE-CREATION 
>   components/baloodatamodel/baloodatamodel.h PRE-CREATION 
>   components/baloodatamodel/baloodatamodel.cpp PRE-CREATION 
>   components/baloodatamodel/baloodatamodelplugin.h PRE-CREATION 
>   components/baloodatamodel/baloodatamodelplugin.cpp PRE-CREATION 
>   components/baloodatamodel/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119617/diff/
> 
> 
> Testing
> -------
> 
> Everything works, we can get:
> 
> * the file id
> * the file icon
> * the file url
> * the file text
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140805/c9611f1c/attachment.html>