Review Request 119602: support config dialog with current krunner config dialog

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119602/#review63813
-----------------------------------------------------------


Please make sure all the comments from the previous review are also addressed.


kcms/runners/kcm.h
<https://git.reviewboard.kde.org/r/119602/#comment44471>

    This variable does not seem to be used.



kcms/runners/kcm.cpp
<https://git.reviewboard.kde.org/r/119602/#comment44472>

    Please use !isEmpty()



kcms/runners/kcm.cpp
<https://git.reviewboard.kde.org/r/119602/#comment44470>

    QScopedPointer perhaps? Or just allocate it off the stack.
    
    Do we really need the deleteLater in the end? Also, right now we're leaking this pointer in line 152.



kcms/runners/kcm.cpp
<https://git.reviewboard.kde.org/r/119602/#comment44473>

    New signal slots would be nice, though not required.



kcms/runners/kcm.cpp
<https://git.reviewboard.kde.org/r/119602/#comment44474>

    why do we need these parentComponents?



kcms/runners/kcm.cpp
<https://git.reviewboard.kde.org/r/119602/#comment44475>

    not required.



kcms/runners/kcm.cpp
<https://git.reviewboard.kde.org/r/119602/#comment44469>

    Please use !isEmpty() instead


- Vishesh Handa


On Aug. 4, 2014, 5:02 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119602/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 5:02 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> unlike the previous one, this still uses category based config.
> tough, if in a category there are runners with a config dialog, enable a config button in the item.
> If there would be more runners with config in one category, it would put all the config dialogs in a tabbar.
> The code for showing the config dialog comes from KPluginLoader
> 
> 
> Diffs
> -----
> 
>   kcms/runners/kcm.h 0458430 
>   kcms/runners/kcm.cpp 0de07fb 
> 
> Diff: https://git.reviewboard.kde.org/r/119602/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> krunner.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/04/447dbfb8-e813-4cb9-aabb-a2b9f8d324a0__krunner.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140804/80067351/attachment-0001.html>