Review Request 119534: take defaults from a plasma look and feel package, if available

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119534/#review63812
-----------------------------------------------------------



src/platformtheme/khintssettings.cpp
<https://git.reviewboard.kde.org/r/119534/#comment44468>

    This is broken I think.
    
    If I have my preferred style set to windows because the list already contains that it won't change anything.
    
    This means my list is still oxygen, fusion, windows in that order.
    
    It think it should be
    
    if (!lnfStyle.isEmpty()) {
       styleNames.removeOne(lnfStyle);
       styleNames.prepend(lnfStyle);
    }
    
    or we could change line 76 to use readConfigValue ?


- David Edmundson


On Aug. 4, 2014, 3:18 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119534/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 3:18 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> there will be support for some kind of "mega theme" that besides providing files for splashscreen, lockscreen etc, will define what defaults to use among icons, colors, fonts etc.
> 
> This is a first start of it for reading the defaults. The theme file is stored in a plasma package, but the patch resolves the correct path by hand, not requiring linking to libplasma.
> right now only a couple of settings is used, mostly to see if the direction is good.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/khintssettings.h 57f1864 
>   src/platformtheme/khintssettings.cpp f9e068d 
> 
> Diff: https://git.reviewboard.kde.org/r/119534/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140804/b4474174/attachment.html>