Review Request 118406: Notify the user if the location containing the media is inaccessible.

[R.Harish Navnit]

> On Aug. 1, 2014, 5:36 p.m., Sinny Kumari wrote:
> > Couple of issues:
> > 1. While I am playing songs from playlist, suppose there are three inaccessible media in between. Now, I press next then control will skip 3 inacessible media and will play 4th one. Now, if I press previous, it should play last accesible media i.e media before 3 inaccesible media but here it keeps playing same.
> > 2. As Thomas suggested, in playlist we should Grey out the entry in the playlist for inaccessible media. This may be fixed in same review or maybe in a new review request
> > 3. When playing inaccessible media from mediabrowser, show only error message in videoplayer, don't show music icon. Looks clutter due to that.

I'm working on rectifying 1. I'd need some help with 2(I've tried to do that in the same patch) but I seem to be going nowhere. I'm not sure I understand what you're trying to say in 3.


- R.Harish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118406/#review63648
-----------------------------------------------------------


On Aug. 1, 2014, 4:03 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118406/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2014, 4:03 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Bugs: 333764
>     http://bugs.kde.org/show_bug.cgi?id=333764
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> If a media(in a playlist) is located in an inaccessible location, then the user is notified about the same. 
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediaplayer/MediaPlayer.qml 98f1d2c 
>   mediaelements/playlist/Playlist.qml 5dde297 
> 
> Diff: https://git.reviewboard.kde.org/r/118406/diff/
> 
> 
> Testing
> -------
> 
> 1. Load media to a playlist.
> 2. Unmount the device containing media.
> 3. Check if the user is notified of the location being inaccessible
>    --yes, the user is notified
> 4. Mount the device containing media and play a media from playlist.
>    -- The media plays properly.
> 
> 
> File Attachments
> ----------------
> 
> wihtout_i18n.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/05/3dc148a5-c4da-4d27-a713-e63922cbcef8__wihtout_i18n.png
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140804/df92ab7f/attachment-0001.html>