Review Request 119602: support config dialog with current krunner config dialog

[Marco Martin]

> On Aug. 4, 2014, 2:37 p.m., Vishesh Handa wrote:
> > kcms/runners/kcm.cpp, line 90
> > <https://git.reviewboard.kde.org/r/119602/diff/1/?file=295321#file295321line90>
> >
> >     Just to be sure, the code path where the tab widget is used is completely untested, right? Or are there some plugins which provide the same categories?

yes :) I'll probably test making some runners telling fake categories just to get this tested before merging tough


> On Aug. 4, 2014, 2:37 p.m., Vishesh Handa wrote:
> > kcms/runners/kcm.cpp, line 159
> > <https://git.reviewboard.kde.org/r/119602/diff/1/?file=295321#file295321line159>
> >
> >     I'm confused. When the user clicks cancel, then we reload all these proxy modules? And then we delete all of them?

right, i ported it from KPluginLoader without paying much attention, no idea why it did this, since it looks really useless


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119602/#review63780
-----------------------------------------------------------


On Aug. 4, 2014, 3:55 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119602/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 3:55 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> unlike the previous one, this still uses category based config.
> tough, if in a category there are runners with a config dialog, enable a config button in the item.
> If there would be more runners with config in one category, it would put all the config dialogs in a tabbar.
> The code for showing the config dialog comes from KPluginLoader
> 
> 
> Diffs
> -----
> 
>   kcms/runners/kcm.cpp 0de07fb 
>   kcms/runners/kcm.h 0458430 
> 
> Diff: https://git.reviewboard.kde.org/r/119602/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> krunner.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/04/447dbfb8-e813-4cb9-aabb-a2b9f8d324a0__krunner.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140804/aa0bf5d4/attachment.html>