Review Request 119575: Fix krunner contacts pllugin

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119575/#review63772
-----------------------------------------------------------



runners/contacts/contactsrunner.cpp
<https://git.reviewboard.kde.org/r/119575/#comment44443>

    I don't see the point of this slot at all - the exec() call is blocking and you just extract the results via job->contacts() on l. 67, and looking at the code of this slot, it just extracts the results and does nothing with them :-) I think you can remove the slot completely.


- Dan Vrátil


On Aug. 4, 2014, 12:40 a.m., Marc Deop wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119575/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 12:40 a.m.)
> 
> 
> Review request for KDEPIM and Plasma.
> 
> 
> Bugs: 282567
>     http://bugs.kde.org/show_bug.cgi?id=282567
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Fix krunner contacts plugin to lookup contacts through Akonadi
> 
> 
> Diffs
> -----
> 
>   runners/contacts/contactsrunner.h 9bcb40d34a40dad414ea5154b745c97c18d6d81b 
>   runners/contacts/contactsrunner.cpp 2261e3744c695d046ec95e6dd97f1ad26c800d71 
> 
> Diff: https://git.reviewboard.kde.org/r/119575/diff/
> 
> 
> Testing
> -------
> 
> Compiled, installed and tested locally
> 
> 
> Thanks,
> 
> Marc Deop
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140804/2408f5d4/attachment.html>