Review Request 119554: Plasmoid initialization, screenForContainment

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119554/
-----------------------------------------------------------

(Updated Aug. 4, 2014, 1:23 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Bugs: 335710
    https://bugs.kde.org/show_bug.cgi?id=335710


Repository: plasma-workspace


Description
-------

So far, when initializing plasma shell some plasmoids would trigger a warning in ShellCorona::screenForContainment saying that the requested screen was not found.

This patch fixes the issue by introducing the screens to the views list earlier, this way when screenForContainment is called, we already have the list initialized. Now the problem is that we get some inconsistencies, because QApp::processEvents is called from within View::setContainment. This results in requests to the PlasmaShell on half-baked instances and resulted in problems. That's why I introduced the loading attribute that wraps setContainment calls.


Diffs
-----

  shell/shellcorona.cpp 09ef711 

Diff: https://git.reviewboard.kde.org/r/119554/diff/


Testing
-------

PlasmaShell seems to run fine on my system.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140804/13baf17b/attachment-0001.html>