Review Request 119575: Fix krunner contacts pllugin

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119575/#review63680
-----------------------------------------------------------


Thanks for the patch. Please add someone from kdepim team to review.


runners/contacts/contactsrunner.cpp
<https://git.reviewboard.kde.org/r/119575/#comment44360>

    Stray new line



runners/contacts/contactsrunner.cpp
<https://git.reviewboard.kde.org/r/119575/#comment44361>

    Please no spaces inside parentheses
    Occurs multiple times



runners/contacts/contactsrunner.cpp
<https://git.reviewboard.kde.org/r/119575/#comment44359>

    Wrong indentation on these two lines



runners/contacts/contactsrunner.cpp
<https://git.reviewboard.kde.org/r/119575/#comment44358>

    Trailing whitespace


- Christoph Feck


On Aug. 2, 2014, 2:37 p.m., Marc Deop wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119575/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2014, 2:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 282567
>     http://bugs.kde.org/show_bug.cgi?id=282567
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Fix krunner contacts plugin to lookup contacts through Akonadi
> 
> 
> Diffs
> -----
> 
>   runners/contacts/contactsrunner.h 9bcb40d34a40dad414ea5154b745c97c18d6d81b 
>   runners/contacts/contactsrunner.cpp 2261e3744c695d046ec95e6dd97f1ad26c800d71 
> 
> Diff: https://git.reviewboard.kde.org/r/119575/diff/
> 
> 
> Testing
> -------
> 
> Compiled, installed and tested locally
> 
> 
> Thanks,
> 
> Marc Deop
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140802/0906c7c1/attachment.html>