Review Request 118406: Notify the user if the location containing the media is inaccessible.

Thomas Pfeiffer colomar at autistici.org
Sat Aug 2 00:55:06 UTC 2014



> On Aug. 1, 2014, 5:36 p.m., Sinny Kumari wrote:
> > mediaelements/mediaplayer/MediaPlayer.qml, line 108
> > <https://git.reviewboard.kde.org/r/118406/diff/3/?file=294832#file294832line108>
> >
> >     Rather than saying "Please make sure the location is accessible and try again" , it should be "please make sure media exists". Media inaccesible could be due to multiple reason like renaming of media, deleting media or unmounting partition/device which is kind of deletion of media for my computer.
> 
> Ashish Madeti wrote:
>     Is it guaranteed that the error in video can only arise due to location not accessible (or because the file does not exist)? I have seen the same screen (as mentioned in the bug, https://docs.google.com/file/d/0Bxf5QIFnNjVeRHFCdzFkTVRtRDA) when the necessary codecs are not present.
>     In that case, I guess we need some generic error message.

If files being unplayable due to missing codecs, a different message has to be shown. If we wrote a message generic enough to cover both cases, it would be too generic to be of any value to the user.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118406/#review63648
-----------------------------------------------------------


On Aug. 1, 2014, 4:03 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118406/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2014, 4:03 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Bugs: 333764
>     http://bugs.kde.org/show_bug.cgi?id=333764
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> If a media(in a playlist) is located in an inaccessible location, then the user is notified about the same. 
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediaplayer/MediaPlayer.qml 98f1d2c 
>   mediaelements/playlist/Playlist.qml 5dde297 
> 
> Diff: https://git.reviewboard.kde.org/r/118406/diff/
> 
> 
> Testing
> -------
> 
> 1. Load media to a playlist.
> 2. Unmount the device containing media.
> 3. Check if the user is notified of the location being inaccessible
>    --yes, the user is notified
> 4. Mount the device containing media and play a media from playlist.
>    -- The media plays properly.
> 
> 
> File Attachments
> ----------------
> 
> wihtout_i18n.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/05/3dc148a5-c4da-4d27-a713-e63922cbcef8__wihtout_i18n.png
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140802/763a858e/attachment.html>


More information about the Plasma-devel mailing list