Review Request 118406: Notify the user if the location containing the media is inaccessible.

R.Harish Navnit harishnavnit at gmail.com
Fri Aug 1 17:22:34 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118406/#review63647
-----------------------------------------------------------



mediaelements/mediaplayer/MediaPlayer.qml
<https://git.reviewboard.kde.org/r/118406/#comment44344>

    I don't get what you mean. This statement is working(in the sense that the media is getting skipped). Can you elaborate ?



mediaelements/playlist/Playlist.qml
<https://git.reviewboard.kde.org/r/118406/#comment44343>

    you mean the entire method is not required or just the statment inside(which isn't really helping, I wanted some help so I kept it) ?
    
    Which element's property(opacity) should I change to show that the media is inaccessible.


- R.Harish  Navnit


On Aug. 1, 2014, 4:03 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118406/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2014, 4:03 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Bugs: 333764
>     http://bugs.kde.org/show_bug.cgi?id=333764
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> If a media(in a playlist) is located in an inaccessible location, then the user is notified about the same. 
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediaplayer/MediaPlayer.qml 98f1d2c 
>   mediaelements/playlist/Playlist.qml 5dde297 
> 
> Diff: https://git.reviewboard.kde.org/r/118406/diff/
> 
> 
> Testing
> -------
> 
> 1. Load media to a playlist.
> 2. Unmount the device containing media.
> 3. Check if the user is notified of the location being inaccessible
>    --yes, the user is notified
> 4. Mount the device containing media and play a media from playlist.
>    -- The media plays properly.
> 
> 
> File Attachments
> ----------------
> 
> wihtout_i18n.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/05/3dc148a5-c4da-4d27-a713-e63922cbcef8__wihtout_i18n.png
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140801/e4b31d18/attachment.html>


More information about the Plasma-devel mailing list