Review Request 117867: Do not cache media lists to a database

[Sinny Kumari]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117867/#review57015
-----------------------------------------------------------



libs/mediacenter/CMakeLists.txt
<https://git.reviewboard.kde.org/r/117867/#comment39730>

    ${QT_QTSQL_LIBRARIES} shouldn't be required



libs/mediacenter/CMakeLists.txt
<https://git.reviewboard.kde.org/r/117867/#comment39729>

    ${Boost_LIBRARIES} shouldn't be required



libs/mediacenter/CMakeLists.txt
<https://git.reviewboard.kde.org/r/117867/#comment39728>

    ${QT_QTSQL_LIBRARIES} and ${Boost_LIBRARIES shouldn't be needed now



libs/mediacenter/medialibrary.h
<https://git.reviewboard.kde.org/r/117867/#comment39731>

    shouldn't be required


- Sinny Kumari


On April 29, 2014, 1:13 p.m., Shantanu Tushar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117867/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 1:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> We started caching results from media sources due to our primary data source (Nepomuk) was quite slow and the experience was quite bad both for fetching media and searching through it. Going forward, Baloo is our primary data source, and was found to be quite performant. Given this, the additional complexity of maintaining a cache in DB is too much for the 1-2 second increase in Media Library load times.
> 
> Note that we are still able to pull in data from multiple data sources, we just won't store it on disk.
> 
> 
> Diffs
> -----
> 
>   README be3e060 
>   cmake/FindQxOrm.cmake 3c1fae1 
>   libs/CMakeLists.txt 32d45c2 
>   libs/mediacenter/CMakeLists.txt 809d2c0 
>   libs/mediacenter/album.h 64b1205 
>   libs/mediacenter/album.cpp 391a420 
>   libs/mediacenter/artist.h 064aa02 
>   libs/mediacenter/artist.cpp 6b32269 
>   libs/mediacenter/media.h 830ad57 
>   libs/mediacenter/media.cpp a56a693 
>   libs/mediacenter/medialibrary.h 8f9b5d3 
>   libs/mediacenter/medialibrary.cpp 8f49c05 
>   libs/mediacenter/pmcalbum.h 40c42fe 
>   libs/mediacenter/pmcartist.h f15a2e2 
>   libs/mediacenter/pmcmedia.cpp d94d6c7 
>   libs/mediacenter/precompiled.h 73490b8 
>   libs/mediacenter/qxorm_export.h 33fbf11 
>   libs/mediacenter/test/medialibrarytest.h 2f8b476 
>   libs/mediacenter/test/medialibrarytest.cpp bb20a61 
>   libs/mediacenter/test/mediatest.h 965bc7e 
>   libs/mediacenter/test/mediatest.cpp 4f44334 
> 
> Diff: https://git.reviewboard.kde.org/r/117867/diff/
> 
> 
> Testing
> -------
> 
> Unit tests pass, functionality works as expected.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140430/8fb8a6a9/attachment-0001.html>