Review Request 117897: Don't hide Dialog with hideOnWindowDeactivate==true on focus out when dialog is ancestor of new focus window

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117897/#review56976
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On April 30, 2014, 11:59 a.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117897/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 11:59 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Dialog::hideOnWindowDeactivate is evaluated in Dialog::focusOutEvent, i.e. if it's true and the dialog loses focus, the dialog will hide.
> 
> This means dialogs that open sub windows (sub dialogs, or QMenusfor that matter) need to carefully manage hideOnWindowDeactivate to be false for the duration of the sub window being open.
> 
> This can mean a lot of scaffolding, and duplication thereof across various applets. For example, Kickoff manages hideOnWindowDeactivate for its context menus. So does Kicker, and Kicker also has to concern itself with sub dialogs, where it needs to interact in complicated ways with open/close management for subdialogs.
> 
> This patch introduces the assumption that if the focus loss is due to a child window of the dialog gaining focus, the dialog shouldn't actually be hidden, simplifying applet code.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp 58de55b 
> 
> Diff: https://git.reviewboard.kde.org/r/117897/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140430/702fe68a/attachment.html>