Review Request 117876: rename kuiserver to kuiserver5 for coinstallability

Hrvoje Senjan hrvoje.senjan at gmail.com
Wed Apr 30 09:27:02 UTC 2014



> On April 30, 2014, 12:56 a.m., Hrvoje Senjan wrote:
> > kuiserver/CMakeLists.txt, line 73
> > <https://git.reviewboard.kde.org/r/117876/diff/2/?file=269233#file269233line73>
> >
> >     i guess also org.kde.kuiserver.service would need adjusting ...
> 
> Marco Martin wrote:
>     shouldn't the services maintain their name? i don't think we want co-runnability no? (if changed everybody using them should be adapted, leading to things breaking with no obvious reasons)
> 
> Jonathan Riddell wrote:
>     The patch does rename org.kde.kuiserver.service.  
>     
>     From http://www.freedesktop.org/wiki/IntroductionToDBus/  "write a service file "bankcounter.service" (the name is arbitrary, so long as it ends with .service)"

i meant more the exec line in the service =)


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117876/#review56933
-----------------------------------------------------------


On April 30, 2014, 11:20 a.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117876/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 11:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with plasma next.  rename to kuiserver5.
> 
> 
> Diffs
> -----
> 
>   kuiserver/CMakeLists.txt 6d79b41 
>   kuiserver/kuiserver.desktop 2dec197 
> 
> Diff: https://git.reviewboard.kde.org/r/117876/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140430/81076aa5/attachment.html>


More information about the Plasma-devel mailing list