Review Request 117891: Fix x/y property values in DeclarativeDragDropEvent

Eike Hein hein at kde.org
Wed Apr 30 06:37:09 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117891/
-----------------------------------------------------------

(Updated April 30, 2014, 6:37 a.m.)


Review request for Plasma and Marco Martin.


Changes
-------

Actually just don't do any of this unnecessary work ...


Repository: kdeclarative


Description
-------

DeclarativeDragDropEvent runs the coordinates it gets from QQuickItem::dragMoveEvent through mapFromScene(), which is unnecessary - the coordinates are already in the item's reference frame - and actually causes them to be wrong when a DeclarativeDropArea isn't at QPoint(0,0) in the scene.


Diffs (updated)
-----

  src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp 374a09b 

Diff: https://git.reviewboard.kde.org/r/117891/diff/


Testing
-------


Thanks,

Eike Hein

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140430/dbfbd1e1/attachment.html>


More information about the Plasma-devel mailing list