Review Request 117775: rename oxygen sound files for co-installability

Aleix Pol Gonzalez aleixpol at kde.org
Tue Apr 29 11:04:08 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117775/#review56859
-----------------------------------------------------------


Wouldn't it make more sense to have sounds/oxygen and sounds/breeze?

- Aleix Pol Gonzalez


On April 29, 2014, 9:40 a.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117775/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 9:40 a.m.)
> 
> 
> Review request for Plasma and Jens Rutschmann.
> 
> 
> Repository: oxygen
> 
> 
> Description
> -------
> 
> Oxygen sound files were part of kde-runtime so need to be co-installable with kdelibs4 world.  Use Oxygen name to give them a different name and correct identify the sound theme.  There are various .notifyrc files that use these files which I'll submit patches for should this one be accepted.
> 
> 
> Diffs
> -----
> 
>   sounds/KDE-Im-Cant-Connect.ogg  
>   sounds/KDE-Im-Connection-Lost.ogg  
>   sounds/KDE-Im-Contact-In.ogg  
>   sounds/KDE-Im-Contact-Out.ogg  
>   sounds/KDE-Im-Error-On-Connection.ogg  
>   sounds/KDE-Im-Highlight-Msg.ogg  
>   sounds/KDE-Im-Internal-Error.ogg  
>   sounds/KDE-Im-Irc-Event.ogg  
>   sounds/KDE-Im-Low-Priority-Message.ogg  
>   sounds/KDE-Im-Message-In.ogg  
>   sounds/KDE-Im-Message-Out.ogg  
>   sounds/KDE-Im-Network-Problems.ogg  
>   sounds/KDE-Im-New-Mail.ogg  
>   sounds/KDE-Im-Nudge.ogg  
>   sounds/KDE-Im-Phone-Ring.ogg  
>   sounds/KDE-Im-Sms.ogg  
>   sounds/KDE-Im-User-Auth.ogg  
>   sounds/KDE-K3B-Finish-Error.ogg  
>   sounds/KDE-K3B-Finish-Success.ogg  
>   sounds/KDE-K3B-Insert-Medium.ogg  
>   sounds/KDE-Sys-App-Error-Critical.ogg  
>   sounds/KDE-Sys-App-Error-Serious-Very.ogg  
>   sounds/KDE-Sys-App-Error-Serious.ogg  
>   sounds/KDE-Sys-App-Error.ogg  
>   sounds/KDE-Sys-App-Message.ogg  
>   sounds/KDE-Sys-App-Negative.ogg  
>   sounds/KDE-Sys-App-Positive.ogg  
>   sounds/KDE-Sys-Error-Printing.ogg  
>   sounds/KDE-Sys-File-Open-Foes.ogg  
>   sounds/KDE-Sys-List-End.ogg  
>   sounds/KDE-Sys-List-Match-Multiple.ogg  
>   sounds/KDE-Sys-List-Match-No.ogg  
>   sounds/KDE-Sys-Log-In-Long.ogg  
>   sounds/KDE-Sys-Log-In-Short.ogg  
>   sounds/KDE-Sys-Log-In.ogg  
>   sounds/KDE-Sys-Log-Out.ogg  
>   sounds/KDE-Sys-Question.ogg  
>   sounds/KDE-Sys-Special.ogg  
>   sounds/KDE-Sys-Trash-Emptied.ogg  
>   sounds/KDE-Sys-Warning.ogg  
>   sounds/KDE-Window-All-Desktops-Not.ogg  
>   sounds/KDE-Window-All-Desktops.ogg  
>   sounds/KDE-Window-Close.ogg  
>   sounds/KDE-Window-Maximize.ogg  
>   sounds/KDE-Window-Minimize.ogg  
>   sounds/KDE-Window-Move-Stop.ogg  
>   sounds/KDE-Window-Move.ogg  
>   sounds/KDE-Window-Shade-Down.ogg  
>   sounds/KDE-Window-Shade-Up.ogg  
> 
> Diff: https://git.reviewboard.kde.org/r/117775/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140429/2d2b56eb/attachment-0001.html>


More information about the Plasma-devel mailing list